storage: remove kv.learner_replicas.enabled cluster setting #40253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To remove preemptive snapshot code in 20.1, among other things we need to guarantee that no-one is still using them in 19.2, which means we cannot offer the fallback of turning them off. They've been defaulted on for a few weeks, so hopefully we've found most of the major issues and any remaining ones will shake out in stability period. Release note: None
|
This change is |
tbg
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
TFTR! bors r=tbg |
craig bot
pushed a commit
that referenced
this pull request
Aug 27, 2019
40253: storage: remove kv.learner_replicas.enabled cluster setting r=tbg a=danhhz To remove preemptive snapshot code in 20.1, among other things we need to guarantee that no-one is still using them in 19.2, which means we cannot offer the fallback of turning them off. They've been defaulted on for a few weeks, so hopefully we've found most of the major issues and any remaining ones will shake out in stability period. Release note: None Co-authored-by: Daniel Harrison <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To remove preemptive snapshot code in 20.1, among other things we need
to guarantee that no-one is still using them in 19.2, which means we
cannot offer the fallback of turning them off. They've been defaulted on
for a few weeks, so hopefully we've found most of the major issues and
any remaining ones will shake out in stability period.
Release note: None