sql: Skip creation/update of job for schema change in same txn as CREATE #39819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would unconditionally create a job for a schema change issued in the same txn as the one in which its table was created. This is contrary to how we would handle these schema changes. In such scenarios schema changes would be applied synchronously without using the schema changer. Thus, these jobs would indefinitely remain in a pending state. This change adds a condition to check whether job creation is necessary. It fixes one symptom of cockroachdb#39667. Release note: None
|
This change is |
dt
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
Thanks!
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @BramGruneir)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 22, 2019
39819: sql: Skip creation/update of job for schema change in same txn as CREATE r=adityamaru27 a=adityamaru27 Previously, we would unconditionally create a job for a schema change issued in the same txn as the one in which its table was created. This is contrary to how we would handle these schema changes. In such scenarios schema changes would be applied synchronously without using the schema changer. Thus, these jobs would indefinitely remain in a pending state. This change adds a condition to check whether job creation is necessary. It fixes one symptom of #39667. Release note: None Co-authored-by: Aditya Maru <[email protected]>
Build succeeded |
|
Does this need to be backported? @BramGruneir @dt @lucy-zhang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would unconditionally create a job for a schema change
issued in the same txn as the one in which its table was created. This
is contrary to how we would handle these schema changes. In such
scenarios schema changes would be applied synchronously without using
the schema changer. Thus, these jobs would indefinitely remain in a pending
state.
This change adds a condition to check whether job creation is necessary.
It fixes one symptom of #39667.
Release note: None