Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: Bump min version for direct ingest import roachtest #39463

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

adityamaru27
Copy link
Contributor

@adityamaru27 adityamaru27 commented Aug 8, 2019

Bumping the roachtest version to 19.2.0 to ensure it runs on
master branch.

Closes: #39395

Release note: None

Bumping the roachtest version to 19.2.0 to ensure it runs on
master branch.

Release note: None
@adityamaru27 adityamaru27 requested a review from dt August 8, 2019 17:26
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru27 adityamaru27 changed the title roachtest: Bump min version for direct ingest import roachtesti roachtest: Bump min version for direct ingest import roachtest Aug 8, 2019
@adityamaru27
Copy link
Contributor Author

bors r+

craig bot pushed a commit that referenced this pull request Aug 8, 2019
39439: sql: optimizer always on r=RaduBerinde a=RaduBerinde

#### sql, workload: don't disable the optimizer in tests

In preparation for removing the possibility of turning off the
optimizer, adjust tests and benchmarks that are disabling the
optimizer.

Release note: None

#### sql: optimizer always on

This change deprecates the `optimizer` session setting and associated
cluster setting. It is no longer possible to disable the optimizer.
The settings still exist but the only allowed value is "on" (mostly so
that `SET OPTIMIZER = ON` still works).

The logic test configurations are reworked: they now all use the
optimizer, and the `-opt` versions are gone (e.g. what used to be
`local-opt` is now `local`). The HP-specific planner tests are
removed.

Release note: None


39463: roachtest: Bump min version for direct ingest import roachtest r=adityamaru27 a=adityamaru27

Bumping the roachtest version to 19.2.0 to ensure it runs on
master branch.

Closes: #39395

Release note: None

39467: roachtest: add backward compat to replicate/wide r=solongordon a=solongordon

In 6c24930, I updated the way replication zones are named, which
affected the replicate/wide roachtest. However I neglected to add
backward compatibility for testing against previous releases. This
commit restores the old logic for that scenario.

Release note: None

Co-authored-by: Radu Berinde <[email protected]>
Co-authored-by: Aditya Maru <[email protected]>
Co-authored-by: Solon Gordon <[email protected]>
@craig
Copy link
Contributor

craig bot commented Aug 8, 2019

Build succeeded

@craig craig bot merged commit 442a934 into cockroachdb:master Aug 8, 2019
@adityamaru27 adityamaru27 deleted the bump-min-version branch August 8, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: import/experimental-direct-ingestion failed
3 participants