workload/ycsb: implement read-modify-write

[jeffrey-xiao]

Release note: None

[cockroach-teamcity]

This change is 

[ajwerner]

Nice

Reviewed 1 of 1 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @jeffrey-xiao and @nvanbenschoten)

---

pkg/workload/ycsb/ycsb.go, line 578 at r1 (raw file):

			return err
		}
		for res.Next() {

Should this ever read more than one row? If not you could do QueryRowContext

[nvanbenschoten]

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @jeffrey-xiao)

---

pkg/workload/ycsb/ycsb.go, line 300 at r1 (raw file):

	}

	readStmts := make([]*gosql.Stmt, numTableFields)

nit: move up next to readStmt and rename to readFieldStmts. Same thing in the ycsbWorker struct.

[nvanbenschoten]

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @jeffrey-xiao)

---

pkg/workload/ycsb/ycsb.go, line 571 at r1 (raw file):

	value := yw.randString(fieldLength)
	fieldIdx := yw.rng.Intn(numTableFields)
	args := make([]interface{}, 2)

You can use an array here without it escaping. Could you do that here, in insertRow, and in updateRow? Something like:

diff --git a/pkg/workload/ycsb/ycsb.go b/pkg/workload/ycsb/ycsb.go
index 4d92b018db..f2d9356556 100644
--- a/pkg/workload/ycsb/ycsb.go
+++ b/pkg/workload/ycsb/ycsb.go
@@ -484,12 +484,12 @@ func (yw *ycsbWorker) randString(length int) string {
 }

 func (yw *ycsbWorker) insertRow(ctx context.Context, keyIndex uint64, increment bool) error {
-       args := make([]interface{}, numTableFields+1)
+       var args [numTableFields + 1]interface{}
        args[0] = yw.buildKeyName(keyIndex)
        for i := 1; i <= numTableFields; i++ {
                args[i] = yw.randString(fieldLength)
        }
-       if _, err := yw.insertStmt.ExecContext(ctx, args...); err != nil {
+       if _, err := yw.insertStmt.ExecContext(ctx, args[:]...); err != nil {
                yw.nextInsertIndex = new(uint64)
                *yw.nextInsertIndex = keyIndex
                return err
@@ -509,7 +509,7 @@ func (yw *ycsbWorker) insertRow(ctx context.Context, keyIndex uint64, increment

 func (yw *ycsbWorker) updateRow(ctx context.Context) error {
        var stmt *gosql.Stmt
-       args := make([]interface{}, 2)
+       var args [2]interface{}
        args[0] = yw.nextReadKey()
        fieldIdx := yw.rng.Intn(numTableFields)
        value := yw.randString(fieldLength)
@@ -520,7 +520,7 @@ func (yw *ycsbWorker) updateRow(ctx context.Context) error {
                stmt = yw.updateStmts[fieldIdx]
                args[1] = value
        }
-       if _, err := stmt.ExecContext(ctx, args...); err != nil {
+       if _, err := stmt.ExecContext(ctx, args[:]...); err != nil {
                return err
        }
        return nil

[nvanbenschoten]

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @ajwerner and @jeffrey-xiao)

---

pkg/workload/ycsb/ycsb.go, line 506 at r2 (raw file):

func (yw *ycsbWorker) insertRow(ctx context.Context) error {
	var args [numTableFields]interface{}

numTableFields + 1

[jeffrey-xiao]

TFTRs!

bors r+

[craig]

Build succeeded

• GitHub CI (Cockroach)