Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: upgrade jsdoc version to allow Node 12 #39315

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Conversation

benesch
Copy link
Contributor

@benesch benesch commented Aug 5, 2019

Generating TypeScript protobuf definitions was failing on Node 12,
because pbts was depending on an old version of jsdoc, which was in turn
depending on a library called requizzle, which was incompatible with
Node 12. Bump the version of jsdoc in the lockfile so we can
transitively pick up a newer version of requizzle that does support
Node 12.

See also: protobufjs/protobuf.js#1212

Release note: None

@benesch benesch requested review from nvanbenschoten and a team August 5, 2019 02:43
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten
Copy link
Member

@benesch thanks for the patch! To confirm, this supports dev environments running Node 10 and 12, right?

@benesch
Copy link
Contributor Author

benesch commented Aug 5, 2019

Yep! I didn't actually test Node 10 myself, but TeamCity is still using Node 10 (

&& echo 'deb https://deb.nodesource.com/node_10.x xenial main' | tee /etc/apt/sources.list.d/nodesource.list \
) and tests pass, so it must work.

You (or whoever is in charge of the UI these days) should feel free to just take this PR over though. I can't merge the required yarn-vendored patch; plus I've learned that merging build PRs as an outside contributor tends to ruffle feathers internally, since I can't own the fallout. :)

@jordanlewis
Copy link
Member

plus I've learned that merging build PRs as an outside contributor tends to ruffle feathers internally, since I can't own the fallout. :)

Nikhil, we will always appreciate your patches, even if you self merge them! <3

Generating TypeScript protobuf definitions was failing on Node 12,
because pbts was depending on an old version of jsdoc, which was in turn
depending on a library called requizzle, which was incompatible with
Node 12. Bump the version of jsdoc in the lockfile so we can
transitively pick up a newer version of requizzle that does support
Node 12.

See also: protobufjs/protobuf.js#1212

Release note: None
@nvanbenschoten
Copy link
Member

plus I've learned that merging build PRs as an outside contributor tends to ruffle feathers internally, since I can't own the fallout. :)

No ruffled feathers here! These patches are always a big help. Thanks!

bors r=nvanbenschoten

craig bot pushed a commit that referenced this pull request Aug 7, 2019
39315: ui: upgrade jsdoc version to allow Node 12 r=nvanbenschoten a=benesch

Generating TypeScript protobuf definitions was failing on Node 12,
because pbts was depending on an old version of jsdoc, which was in turn
depending on a library called requizzle, which was incompatible with
Node 12. Bump the version of jsdoc in the lockfile so we can
transitively pick up a newer version of requizzle that does support
Node 12.

See also: protobufjs/protobuf.js#1212

Release note: None

Co-authored-by: Nikhil Benesch <[email protected]>
@craig
Copy link
Contributor

craig bot commented Aug 7, 2019

Build succeeded

@craig craig bot merged commit 1f8ea2a into cockroachdb:master Aug 7, 2019
@kenliu
Copy link

kenliu commented Aug 7, 2019

thanks Nikhil

@vilterp
Copy link
Contributor

vilterp commented Aug 15, 2019

So generous of you to fix this Nikhil. Thanks! cc @nathanstilwell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants