-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: upgrade jsdoc version to allow Node 12 #39315
Conversation
@benesch thanks for the patch! To confirm, this supports dev environments running Node 10 and 12, right? |
Yep! I didn't actually test Node 10 myself, but TeamCity is still using Node 10 ( cockroach/build/builder/Dockerfile Line 218 in 6bb1bc5
You (or whoever is in charge of the UI these days) should feel free to just take this PR over though. I can't merge the required yarn-vendored patch; plus I've learned that merging build PRs as an outside contributor tends to ruffle feathers internally, since I can't own the fallout. :) |
Nikhil, we will always appreciate your patches, even if you self merge them! <3 |
Generating TypeScript protobuf definitions was failing on Node 12, because pbts was depending on an old version of jsdoc, which was in turn depending on a library called requizzle, which was incompatible with Node 12. Bump the version of jsdoc in the lockfile so we can transitively pick up a newer version of requizzle that does support Node 12. See also: protobufjs/protobuf.js#1212 Release note: None
No ruffled feathers here! These patches are always a big help. Thanks! bors r=nvanbenschoten |
39315: ui: upgrade jsdoc version to allow Node 12 r=nvanbenschoten a=benesch Generating TypeScript protobuf definitions was failing on Node 12, because pbts was depending on an old version of jsdoc, which was in turn depending on a library called requizzle, which was incompatible with Node 12. Bump the version of jsdoc in the lockfile so we can transitively pick up a newer version of requizzle that does support Node 12. See also: protobufjs/protobuf.js#1212 Release note: None Co-authored-by: Nikhil Benesch <[email protected]>
Build succeeded |
thanks Nikhil |
So generous of you to fix this Nikhil. Thanks! cc @nathanstilwell |
Generating TypeScript protobuf definitions was failing on Node 12,
because pbts was depending on an old version of jsdoc, which was in turn
depending on a library called requizzle, which was incompatible with
Node 12. Bump the version of jsdoc in the lockfile so we can
transitively pick up a newer version of requizzle that does support
Node 12.
See also: protobufjs/protobuf.js#1212
Release note: None