opt: support view and sequence numeric refs

[justinj]

I ended up complicating this much more than necessary - it turns out the
heuristic planner doesn't even support specifying columns for view
numeric references, so this feature is actually really straightforward.

I added a separate test file that is run under the heuristic planner as
well (the existing numeric reference test file panics when run under the
HP, concerningly...).

Release note: None

[cockroach-teamcity]

This change is 

[RaduBerinde]

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @justinj, @RaduBerinde, and @rytaft)

---

pkg/sql/logictest/testdata/logic_test/numeric_references, line 13 at r1 (raw file):

statement error cannot specify an explicit column list when accessing a view by reference
SELECT * FROM [54(1) AS _]

you can use let to get the descriptor id and use that instead of hardcoding it (see https://github.com/cockroachdb/cockroach/blob/master/pkg/sql/logictest/testdata/logic_test/prepare#L1030)

[rytaft]

Reviewed 2 of 4 files at r1, 2 of 2 files at r2.
Reviewable status: complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @justinj)

---

pkg/sql/opt/testutils/testcat/test_catalog.go, line 159 at r2 (raw file):

			return ds, nil
		}
		if v, ok := ds.(*View); ok && v.ViewID == id {

is it worth having an ID() method in the DataSource interface that all of these implement?

[rytaft]

---

pkg/sql/opt/testutils/testcat/test_catalog.go, line 159 at r2 (raw file):

Previously, rytaft (Rebecca Taft) wrote…

is it worth having an ID() method in the DataSource interface that all of these implement?

Actually, Object already has that method, so you should be able to just use it.

[justinj]

TFTRs!

bors r+

[craig]

Build failed

• GitHub CI (Cockroach)

[justinj]

bors r+

[craig]

Build failed (retrying...)

• GitHub CI (Cockroach)

[craig]

Build succeeded

• GitHub CI (Cockroach)