opt: fix casting bug in lookup joiner #38947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Jul 17, 2019
| ---- | ||
|
|
||
| # Projection of constant columns work on boolean expressions. | ||
| # Regression test for a test in opt-private-tests |
There was a problem hiding this comment.
Please remove this line, we shouldn't have this kind of reference here. It's not important how we found the bug anyway.
This change fixes a bug where the lookup joiner assumes any constant value that it needs to create a projection for (because there is a column quality with it) is of the (ConstExpr) type. Regression test added. Release note: None
ridwanmsharif
force-pushed
the
fix-lookup-joiner-bug
branch
from
10a9221 to
fe8daf6
Compare
ridwanmsharif
commented
Jul 18, 2019
There was a problem hiding this comment.
bors r+
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @RaduBerinde)
pkg/sql/opt/xform/testdata/rules/join, line 1463 at r1 (raw file):
Previously, RaduBerinde wrote…
Please remove this line, we shouldn't have this kind of reference here. It's not important how we found the bug anyway.
Done.
craig bot
pushed a commit
that referenced
this pull request
Jul 18, 2019
38947: opt: fix casting bug in lookup joiner r=ridwanmsharif a=ridwanmsharif This change fixes a bug where the lookup joiner assumes any constant value that it needs to create a projection for (because there is a column quality with it) is of the (ConstExpr) type. Regression test added. Release note: None Co-authored-by: Ridwan Sharif <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug where the lookup joiner assumes
any constant value that it needs to create a projection
for (because there is a column quality with it) is of the
(ConstExpr) type. Regression test added.
Release note: None