roachprod: disable ssh logging #38895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was never fully introduced and there is currently no impetus to push it over the finish line. It would be useful to diagnose issues that are readily reproducible, but we haven't seen any of those. Release note: None
|
This change is |
ajwerner
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r=ajwerner |
craig bot
pushed a commit
that referenced
this pull request
Jul 16, 2019
38848: roachpb: further clarify correctness of observed timestamps r=nvanbenschoten a=nvanbenschoten This commit expands on the explanation added in b7cc205. Specifically, it focuses on the inability to bound a transaction's uncertainty interval below the starting timestamp of the lease that it is executing a request on. This limitation was added in 85d4627. I tend to forget about it once every few months and get very confused how this all works. Release note: None 38889: roachtest: create perf artifacts concept and collect them r=nvanbenschoten a=ajwerner Before the roachtest rewrite in #30977 we used to collect the logs directory from remote hosts unconditionally. We also used to write stats.json histogram files to the logs directory. This combination enabled the collection of histogram files for roachperf. Since the new roachtest does not unconditionally copy logs to the test runner, we have not gotten any perf artifacts since the change. This PR introduces a new concept, perf artifacts, which live in a different directory, the perfArtifactsDir. If a testSpec indicates that it HasPerfArtifacts then that directory is copied to the test runner's artifactsDir for that test from each node in the cluster upon success. This change also necessitates a small change to roachperf to look in this new "perf" directory. Fixes #38871. Release note: None 38895: roachprod: disable ssh logging r=ajwerner a=tbg This was never fully introduced and there is currently no impetus to push it over the finish line. It would be useful to diagnose issues that are readily reproducible, but we haven't seen any of those. Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]> Co-authored-by: Andrew Werner <[email protected]> Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was never fully introduced and there is currently no impetus to
push it over the finish line. It would be useful to diagnose issues
that are readily reproducible, but we haven't seen any of those.
Release note: None