opt: update joinSelectivityFromNullCounts to match selectivityFromNullCounts #38795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lCounts A previous PR (cockroachdb#38730) updated the logic in selectivityFromNullCounts to compare the result of floating point arithmetic with a small constant epsilon. For consistency, this commit adds similar logic in joinSelectivityFromNullCounts. Release note: None
|
This change is |
RaduBerinde
approved these changes
Jul 10, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @justinj and @RaduBerinde)
craig bot
pushed a commit
that referenced
this pull request
Jul 10, 2019
38795: opt: update joinSelectivityFromNullCounts to match selectivityFromNullCounts r=rytaft a=rytaft A previous PR (#38730) updated the logic in `selectivityFromNullCounts` to compare the result of floating point arithmetic with a small constant `epsilon`. For consistency, this commit adds similar logic in `joinSelectivityFromNullCounts`. Release note: None Co-authored-by: Rebecca Taft <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR (#38730) updated the logic in
selectivityFromNullCountsto compare the result of floating point arithmetic with a small constant
epsilon. For consistency, this commit adds similar logic injoinSelectivityFromNullCounts.Release note: None