opt: support ALTER TABLE UNSPLIT and EXPERIMENTAL_RELOCATE #38653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for ALTER TABLE UNSPLIT (which has two variants). Release note: None
|
This change is |
justinj
reviewed
Jul 3, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @justinj and @RaduBerinde)
pkg/sql/opt/optbuilder/alter_table.go, line 116 at r1 (raw file):
// Calculate the desired types for the select statement. It is OK if the // select statement returns fewer columns (the relevant prefix is used).
nit: s/select statement/input expression/? It can be a VALUES, right?
Also fix the formatting of details for split/unsplit. Release note: None
RaduBerinde
commented
Jul 3, 2019
There was a problem hiding this comment.
Reviewable status:
pkg/sql/opt/optbuilder/alter_table.go, line 116 at r1 (raw file):
Previously, justinj (Justin Jaffray) wrote…
nit:
s/select statement/input expression/? It can be aVALUES, right?
Done, TFTR!
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 4, 2019
38653: opt: support ALTER TABLE UNSPLIT and EXPERIMENTAL_RELOCATE r=RaduBerinde a=RaduBerinde #### opt: support ALTER TABLE UNSPLIT Support for ALTER TABLE UNSPLIT (which has two variants). Release note: None #### opt: support EXPERIMENTAL_RELOCATE Also fix the formatting of details for split/unsplit. Release note: None Informs #34848. Co-authored-by: Radu Berinde <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opt: support ALTER TABLE UNSPLIT
Support for ALTER TABLE UNSPLIT (which has two variants).
Release note: None
opt: support EXPERIMENTAL_RELOCATE
Also fix the formatting of details for split/unsplit.
Release note: None
Informs #34848.