opt: add support for ALTER TABLE/INDEX SPLIT AT #38585
Conversation
|
This change is |
There was a problem hiding this comment.
cat.Indexs want to know their own ordinal index, which would let ResolveTableIndex keep its (imo more natural?) signature. I guess if this is the only case where it matters then it's unclear.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @justinj and @rytaft)
There was a problem hiding this comment.
Column also doesn't have a method returning its Ordinal, instead we have to store it alongside in IndexColumn. I'm not sure if that was because of a high-level principle or it would have just been hard to implement. For optIndex it should be easy, we just need to add the ordinal as a member. CC @andy-kimball - do you have any thoughts on Index having an Ordinal() method?
Reviewable status:
There was a problem hiding this comment.
It's problematic to store an ordinal in Column, because it would force the creation of a new wrapper object. Right now, we implement the opt.Column interface directly on sqlbase.ColumnDescriptor. I don't see any issue with having an Index remember its ordinal, since we already have a wrapper in that case.
Reviewable status:
Release note: None
|
Ok, dropped the first commit and added an |
There was a problem hiding this comment.
Reviewable status:
Adding optimizer support for `tree.Split`. This statement has a relational input, so it can't be implemented as an "opaque". Note that as part of this change, we move all the "fixed" planNode column definitions to `sqlbase` and we add an `Ordinal()` method to `cat.Index`. Release note: None
|
bors r+ |
38585: opt: add support for ALTER TABLE/INDEX SPLIT AT r=RaduBerinde a=RaduBerinde #### opt: return index ordinal from ResolveTableIndex Release note: None #### optbuilder: add wrapper for building typed scalar Release note: None #### opt: add support for ALTER TABLE/INDEX SPLIT AT Adding optimizer support for `tree.Split`. This statement has a relational input, so it can't be implemented as an "opaque". Release note: None Informs #34848. Co-authored-by: Radu Berinde <[email protected]>
Build succeeded |
opt: return index ordinal from ResolveTableIndex
Release note: None
optbuilder: add wrapper for building typed scalar
Release note: None
opt: add support for ALTER TABLE/INDEX SPLIT AT
Adding optimizer support for
tree.Split. This statement has arelational input, so it can't be implemented as an "opaque".
Release note: None
Informs #34848.