exec: fix null handling in merge joiner #38385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, when a group was buffered, only the values vector has been saved and the null vector has been ignored. Now it is fixed. Additionally, a bug with null handling in the case of a present selection vector is fixed. Release note: None
jordanlewis
approved these changes
Jun 24, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @asubiotto and @jordanlewis)
|
TFTR! Yes, the test exercises both of the bugs. I actually noticed only the "first" one at first, but then when running tests with bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 25, 2019
38385: exec: fix null handling in merge joiner r=yuzefovich a=yuzefovich Previously, when a group was buffered, only the values vector has been saved and the null vector has been ignored. Now it is fixed. Additionally, a bug with null handling in the case of a present selection vector is fixed. Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a group was buffered, only the values vector
has been saved and the null vector has been ignored. Now it is
fixed. Additionally, a bug with null handling in the case of a
present selection vector is fixed.
Release note: None