pkg: Add check disallowing IMPORT INTO a table with secondary indexes. #38327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMPORT INTO will break secondary indexes in the target table as described in issue cockroachdb#38044. This check prevents users from running into this issue until it is resolved. Release note: None
|
This change is |
rolandcrosby
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
Thanks Aditya!
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dt)
dt
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 20, 2019
38327: pkg: Add check disallowing IMPORT INTO a table with secondary indexes. r=adityamaru27 a=adityamaru27 IMPORT INTO will break secondary indexes in the target table as described in issue #38044. This check prevents users from running into this issue until it is resolved. Release note: None Co-authored-by: Aditya Maru <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORT INTO will break secondary indexes in the target table as
described in issue #38044. This check prevents users from
running into this issue until it is resolved.
Release note: None