exec: fix TestSortRandomized flakes #38217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestSortRandomized was failing under stress because sometimes it would randomly generate duplicate sort keys, so there was more than one correct result. I made the final sort column unique so this can't happen. Fixes cockroachdb#38113 Release note: None
|
This change is |
yuzefovich
approved these changes
Jun 17, 2019
There was a problem hiding this comment.
Thanks for the fix!
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 17, 2019
38217: exec: fix TestSortRandomized flakes r=solongordon a=solongordon TestSortRandomized was failing under stress because sometimes it would randomly generate duplicate sort keys, so there was more than one correct result. I made the final sort column unique so this can't happen. Fixes #38113 Release note: None Co-authored-by: Solon Gordon <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestSortRandomized was failing under stress because sometimes it would
randomly generate duplicate sort keys, so there was more than one
correct result. I made the final sort column unique so this can't
happen.
Fixes #38113
Release note: None