storage: remove a couple papercuts in baseQueue/scanner #37943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently no real reason to call addInternal if it's not supposed to do anything. I tracked this parameter back to 24a3f23, which doesn't seem to have a principled reason for introducing it. Release note: None
This RunTask wasn't really getting us anything. RunTask will tell us when the stopper is quiescing, but waitAndProcess already checks the stopper for ShouldStop, which seems sufficient. It also blocks the shutdown (on the mutex lock/unlock?), but this whole method is already in a RunWorker, which does the same thing. Release note: None
|
This change is |
tbg
approved these changes
May 31, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)
|
TFTR! bors r=tbg |
craig bot
pushed a commit
that referenced
this pull request
Jun 3, 2019
37943: storage: remove a couple papercuts in baseQueue/scanner r=tbg a=danhhz See individual commits for details. Found while trying to grok the queue stuff. Both of these tripped me up for a minute -- "why is this necessary?" -- and in both cases I had to convince myself it wasn't. Co-authored-by: Daniel Harrison <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details. Found while trying to grok the queue stuff. Both of these tripped me up for a minute -- "why is this necessary?" -- and in both cases I had to convince myself it wasn't.