storage: fix checksum version check #37868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
force-pushed
the
fix/checksum-versions
branch
from
35983e8 to
ebcb12f
Compare
tbg
force-pushed
the
fix/checksum-versions
branch
from
ebcb12f to
8d3deb2
Compare
ajwerner
approved these changes
May 29, 2019
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @tbg)
pkg/storage/replica_consistency_test.go, line 53 at r1 (raw file):
rc, err := tc.repl.getChecksum(ctx, cc.ChecksumID) if !matchingVersion { require.True(t, testutils.IsError(err, "checksum is nil"))
If I were to ask for something on this change it'd be a comment about why the expected error here is what it is. I might have expected something about version mismatch case rather than just checksum is nil though it all makes sense after reading getChecksum.
Checksum can be nil. Release note: None
The check was sitting at evaluation time, where it is useless. It needs to sit in the below-Raft code that actually computes the checksums. This flew under the radar for quite some time, but was found in: cockroachdb#37737 (comment) thanks to the aggressive consistency checks we run in version/mixed/nodes=3. Release note: None
See cockroachdb#37737 (comment). Release note: None
tbg
force-pushed
the
fix/checksum-versions
branch
from
8d3deb2 to
e13298a
Compare
|
Done, TFTR! bors r=ajwerner |
|
bors r=ajwerner |
craig bot
pushed a commit
that referenced
this pull request
May 30, 2019
37868: storage: fix checksum version check r=ajwerner a=tbg The check was sitting at evaluation time, where it is useless. It needs to sit in the below-Raft code that actually computes the checksums. This flew under the radar for quite some time, but was found in: #37737 (comment) thanks to the aggressive consistency checks we run in version/mixed/nodes=3. Release note: None Co-authored-by: Tobias Schottdorf <[email protected]>
This was referenced May 30, 2019
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check was sitting at evaluation time, where it is useless. It needs to
sit in the below-Raft code that actually computes the checksums.
This flew under the radar for quite some time, but was found in:
#37737 (comment)
thanks to the aggressive consistency checks we run in
version/mixed/nodes=3.
Release note: None