sql: always collect stats after a table is created #37611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
May 21, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @justinj and @RaduBerinde)
justinj
reviewed
May 21, 2019
There was a problem hiding this comment.
Reviewable status:
Prior to this commit, we only collected automatic statistics on a CREATE TABLE statement if it was of the form CREATE TABLE AS <query>. To avoid inconsistencies, this commit changes the logic so we always create statistics on every successful CREATE TABLE statement. Fixes cockroachdb#37362 Release note (sql change): CREATE TABLE statements now always trigger automatic statistics collection on the newly created table.
|
TFTRs! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 21, 2019
37611: sql: always collect stats after a table is created r=rytaft a=rytaft Prior to this commit, we only collected automatic statistics on a `CREATE TABLE` statement if it was of the form `CREATE TABLE AS <query>`. To avoid inconsistencies, this commit changes the logic so we always create statistics on every successful `CREATE TABLE` statement. Fixes #37362 Release note (sql change): CREATE TABLE statements now always trigger automatic statistics collection on the newly created table. Co-authored-by: Rebecca Taft <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we only collected automatic statistics on a
CREATE TABLEstatement if it was of the formCREATE TABLE AS <query>.To avoid inconsistencies, this commit changes the logic so we always
create statistics on every successful
CREATE TABLEstatement.Fixes #37362
Release note (sql change): CREATE TABLE statements now always trigger automatic
statistics collection on the newly created table.