roachprod: don't pollute logs with verbose ssh logs #37594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
approved these changes
May 20, 2019
| @@ -116,6 +116,9 @@ func loadClusters() error { | |||
| return err | |||
| } | |||
|
|
|||
| debugDir := os.ExpandEnv(config.DefaultDebugDir) | |||
There was a problem hiding this comment.
nit: put this in initHostDir and change the name of that function.
ajwerner
approved these changes
May 20, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @ajwerner and @tbg)
I added verbose logging in cockroachdb#37483 but made the poor decision to spew it to stderr when the command exited nonzero. As a consequence, many test failures are now obfuscated by high-verbosity ssh logs. Change the behavior so that the error message is wrapped with a path to the logs. We grab the contents of `~/.roachprod` in CI, so we'll be able to access the logs in the artifacts (`roachprod_state`). ``` $ ./bin/roachprod ssh tobias-test -- echo hi hi $ ls ~/.roachprod/debug/ $ ./bin/roachprod ssh tobias-test -- false Error: ssh verbose log retained in /Users/tschottdorf/.roachprod/debug/ssh_35.231.83.24_2019-05-20T12:53:49Z: exit status 1 $ ls ~/.roachprod/debug/ ssh_35.231.83.24_2019-05-20T12:53:49Z ``` Touches cockroachdb#36963. Release note: None
|
bors r=nvanbenschoten,ajwerner |
craig bot
pushed a commit
that referenced
this pull request
May 20, 2019
37594: roachprod: don't pollute logs with verbose ssh logs r=nvanbenschoten,ajwerner a=tbg I added verbose logging in #37483 but made the poor decision to spew it to stderr when the command exited nonzero. As a consequence, many test failures are now obfuscated by high-verbosity ssh logs. Change the behavior so that the error message is wrapped with a path to the logs. We grab the contents of `~/.roachprod` in CI, so we'll be able to access the logs in the artifacts (`roachprod_state`). ``` $ ./bin/roachprod ssh tobias-test -- echo hi hi $ ls ~/.roachprod/debug/ $ ./bin/roachprod ssh tobias-test -- false Error: ssh verbose log retained in /Users/tschottdorf/.roachprod/debug/ssh_35.231.83.24_2019-05-20T12:53:49Z: exit status 1 $ ls ~/.roachprod/debug/ ssh_35.231.83.24_2019-05-20T12:53:49Z ``` Touches #36963. Release note: None Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added verbose logging in #37483 but made the poor decision to spew it
to stderr when the command exited nonzero. As a consequence, many test
failures are now obfuscated by high-verbosity ssh logs.
Change the behavior so that the error message is wrapped with a path to
the logs. We grab the contents of
~/.roachprodin CI, so we'll be ableto access the logs in the artifacts (
roachprod_state).Touches #36963.
Release note: None