sql: bugfix for planning of wrapped values nodes #37164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Apr 26, 2019
There was a problem hiding this comment.
[nit] s/show_stats/show_zone_config in the commit message (I won't be modifying show_stats, it was just for the reproing).
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @RaduBerinde)
pkg/sql/distsql_physical_planner.go, line 315 at r1 (raw file):
case *unionNode: case *valuesNode: if !n.specifiedInQuery || planCtx.isLocal || planCtx.noEvalSubqueries {
[nit] Move this block outside of the other cases which are all the same. Also remove the else, golint complains.
RaduBerinde
reviewed
Apr 26, 2019
There was a problem hiding this comment.
Verified that the fix works with my show_zone_config change.
Reviewable status:
Previously, there could be a runtime issue if a locally-planned valuesNode produced omitted columns, because there was a mismatch in the code that determined whether nodes had to be wrapped versus the code that produced wrapped nodes. It's hard to write a test for this because there was no way to get this problem before. The upcoming change to show_zone_config will exercise and test this change. Release note: None
jordanlewis
force-pushed
the
fix-wrapped-values
branch
from
0a4f50b to
47616a6
Compare
|
ccache flake. TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 26, 2019
37164: sql: bugfix for planning of wrapped values nodes r=jordanlewis a=jordanlewis Previously, there could be a runtime issue if a locally-planned valuesNode produced omitted columns, because there was a mismatch in the code that determined whether nodes had to be wrapped versus the code that produced wrapped nodes. It's hard to write a test for this because there was no way to get this problem before. The upcoming change to show_stats will exercise and test this change. Fixes #37146. Release note: None Co-authored-by: Jordan Lewis <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there could be a runtime issue if a locally-planned
valuesNode produced omitted columns, because there was a mismatch in the
code that determined whether nodes had to be wrapped versus the code
that produced wrapped nodes.
It's hard to write a test for this because there was no way to get this
problem before. The upcoming change to show_stats will exercise and test
this change.
Fixes #37146.
Release note: None