sql: prevent crash during logging with empty statement #37104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the database would crash if a client sent an empty prepare statement when we had high verbosity on for the conn_executor. Release note: None
|
This change is |
andreimatei
reviewed
Apr 24, 2019
There was a problem hiding this comment.
LGTM but pls add a test :)
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
|
I can't figure out a way to test this reasonably... just going to merge in the name of fixing this bug, sorry! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 26, 2019
37104: sql: prevent crash during logging with empty statement r=jordanlewis a=jordanlewis Previously, the database would crash if a client sent an empty prepare statement when we had high verbosity on for the conn_executor. Release note: None Co-authored-by: Jordan Lewis <[email protected]>
Build succeeded |
This was referenced Jun 24, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the database would crash if a client sent an empty prepare
statement when we had high verbosity on for the conn_executor.
Release note: None