settings/cluster: Add a version to denote work on v19.2. #37006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
bdarnell
approved these changes
Apr 22, 2019
|
This PR replaces #37000. As the commit here is tagged to |
|
I'm actively working on fixing the upgrade cluster acceptance test right now, will merge this once that's fixed. |
Also shrink the name in the upgrade test so that it fits within our cluster name requirements. And also fix the upgrade acceptance test to always check the latest version. Release note: None
BramGruneir
force-pushed
the
bram/version
branch
from
53527b4 to
234aff7
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 23, 2019
37006: settings/cluster: Add a version to denote work on v19.2. r=BramGruneir a=BramGruneir Also shrink the name in the upgrade test so that it fits within our cluster name requirements. Release note: None Co-authored-by: Bram Gruneir <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also shrink the name in the upgrade test so that it fits within our cluster
name requirements.
Release note: None