release-19.1: enable the decoding of single-column family columns of both json and array #36626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm actually surprised this hasn't been tested before. The decoding method was just outright missing. Fixes cockroachdb#36477 Release note: None
Similar to cockroachdb#36548, where arrays were not decoded correctly if they were in a single-column family, jsonb had the same issue. This fixes that. Release note (bug fix): Single column family jsonb columns can now be decoded correctly. From cockroachdb#36548 (bug fix): Single column family array columns can now be decoded correctly.
|
This change is |
BramGruneir
changed the title
bobvawter
approved these changes
Apr 8, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 2 of 2 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @knz)
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
Please see individual PRs for details.
/cc @cockroachdb/release