-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distsqlrun: add missing close call to backfiller #36604
Conversation
Release note: none.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay, but then why have this in the first place if it's not fixing something?
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @lucy-zhang and @vivekmenezes)
I'm not sure I follow: it is fixing something -- the missing In this case that a) prints the on-close summary to the log and b) avoid leaking memory in the c++ SST builder on early error returns. |
Thanks. LGTM! |
bors r+ |
Build failed |
🥐 |
36604: distsqlrun: add missing close call to backfiller r=dt a=dt Release note: none. Co-authored-by: David Taylor <[email protected]>
Build succeeded |
Release note: none.