release-19.1: distsqlpb: rename protos back to distsqlrun #36573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
The move of code to the `distsqlpb` package also inadvertently renamed the actual protobuf service endpoints and messages, which represented an accidental breaking change between 2.1 and 19.1 and would result in errors in mixed clusters. This commit reverts that change, restoring harmony for mixed-version clusters. Release note: None
jordanlewis
force-pushed
the
backport19.1-36572
branch
from
e8db85d to
4a72b8d
Compare
asubiotto
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #36572.
/cc @cockroachdb/release
The move of code to the
distsqlpbpackage also inadvertently renamedthe actual protobuf service endpoints and messages, which represented an
accidental breaking change between 2.1 and 19.1 and would result in
errors in mixed clusters.
This commit reverts that change, restoring harmony for mixed-version
clusters.
This needs a backport and we can't release without that backport.
Touches #36565.
Release note: None