stats: don't spam log with warning messages #36429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a log limiter so that "buffered channel is full" errors are printed at most once per second per node. Fixes cockroachdb#36416 Release note: None
|
This change is |
RaduBerinde
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @justinj and @RaduBerinde)
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 2, 2019
36429: stats: don't spam log with warning messages r=rytaft a=rytaft This commit adds a log limiter so that "buffered channel is full" errors are printed at most once per second per node. Fixes #36416 Release note: None Co-authored-by: Rebecca Taft <[email protected]>
Build succeeded |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a log limiter so that "buffered channel is full"
errors are printed at most once per second per node.
Fixes #36416
Release note: None