roachpb: add canBackpressure request flag #36380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
Release note: None
This commit adds a new request flag that was discussed in cockroachdb#36363. Doing so allows us to remove the `backpressurableReqMethods` set. Release note: None
|
This change is |
ajwerner
approved these changes
Apr 1, 2019
There was a problem hiding this comment.
My guess is that eventually we're going to add another field related to priority which will come in to play when thinking about these back pressure decisions but this yes or no flag is a good start.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 2 of 2 files at r3.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dt)
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 2, 2019
36380: roachpb: add canBackpressure request flag r=nvanbenschoten a=nvanbenschoten This commit adds a new request flag that was discussed in #36363. Doing so allows us to remove the `backpressurableReqMethods` set. Co-authored-by: Nathan VanBenschoten <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new request flag that was discussed in #36363.
Doing so allows us to remove the
backpressurableReqMethodsset.