release-19.1: ui: adjust QPS Summary to match Time Series and Node Map values. #35905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #35693.
/cc @cockroachdb/release
In #283 and #23967,
we note three QPS-related areas in the Admin UI that were causing confusion
for users:
SELECT/INSERT/UPDATE/DELETE
SQL queries.SELECT/INSERT/UPDATE/DELETE
SQL queries.SQL queries (
SELECT/INSERT/UPDATE/DELETE
, but also includes DDL statementsand transaction boundaries).
This commit:
summarize the query types displayed in SQL Queries Time Series Metric and
Node Map
message.
introduce new user questions/confusion.
we actually don't see customers concerned about P50.
likely be from normal SELECT/INSERT/UPDATE/DELETEs. For 50, however,
if clients are doing a large number of complex transactions or SET
commands this could really skew the P50 result.
While this doesn't fully address all the concerns raised from #283 and #23967,
this at least provides a short-term fix of making all the numbers consistent.
Time Series vs Summary Bar. Before (discrepancy of 142.9):
![adriatic off-by-n](https://user-images.githubusercontent.com/3051672/54290723-db120600-4581-11e9-878d-dccd771848fa.png)
Time Series vs Summary Bar. After (sums match up):
![adriatic matches](https://user-images.githubusercontent.com/3051672/54290716-d6e5e880-4581-11e9-8d04-22a3df639265.png)
Node Map vs Summary Bar. After (sums match up):
![adriatic after node-map](https://user-images.githubusercontent.com/3051672/54292511-b79c8a80-4584-11e9-9c5b-087e65fa765a.png)
Updated Summary Bar:
![updated summary bar](https://user-images.githubusercontent.com/3051672/54309359-5b4a6280-45a6-11e9-8fb3-f0850bc3d44e.png)
Release note (admin ui change): 'Queries per second' metric in Summary Bar
adjusted to only summarize the query types displayed in SQL Queries Time
Series Metric and Node Map.