sql: improve error message while adding column with REFERENCE #35697
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @lucy-zhang and @vivekmenezes)
pkg/sql/alter_table.go, line 231 at r1 (raw file):
if _, dropped, inactiveErr := n.tableDesc.FindColumnByName(colName); inactiveErr == nil && !dropped { return pgerror.UnimplementedWithIssueError(32917, "adding a REFERENCES constraint while adding the column in the same transaction not supported")
Is it also possible to get this error when we attempt to add the constraint in a different transaction and see the column in the mutations list?
There was a problem hiding this comment.
Reviewable status:
pkg/sql/alter_table.go, line 231 at r1 (raw file):
Previously, lucy-zhang (Lucy Zhang) wrote…
Is it also possible to get this error when we attempt to add the constraint in a different transaction and see the column in the mutations list?
yes! I should change this error to column still in the process of being backfilled.
vivekmenezes
force-pushed
the
columnrefactor
branch
from
02e061b to
6852f10
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/sql/alter_table.go, line 231 at r1 (raw file):
Previously, vivekmenezes wrote…
yes! I should change this error to column still in the process of being backfilled.
Done.
There was a problem hiding this comment.
Reviewable status:
pkg/sql/alter_table.go, line 231 at r1 (raw file):
Previously, vivekmenezes wrote…
Done.
We might want to say while the column is being added to match the other errors (and also because the backfill might not have started).
vivekmenezes
force-pushed
the
columnrefactor
branch
from
6852f10 to
e8e59f7
Compare
|
bors r+ |
Build failed |
This will eventually be fixed through cockroachdb#32917 Also added a unittest to check that this fails specifically for a column needing a backfill. Release note: None
vivekmenezes
force-pushed
the
columnrefactor
branch
from
e8e59f7 to
639e713
Compare
|
bors r+ |
35697: sql: improve error message while adding column with REFERENCE r=vivekmenezes a=vivekmenezes This will eventually be fixed through #32917 Also added a unittest to check that this fails specifically for a column needing a backfill. Release note: None Co-authored-by: Vivek Menezes <[email protected]>
Build succeeded |
This will eventually be fixed through #32917
Also added a unittest to check that this fails specifically for
a column needing a backfill.
Release note: None