roachtest: misc clearrange improvements #35050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is wildly more efficient. Release note: None
Release note: None
|
This change is |
|
Friendly ping. |
petermattis
approved these changes
Feb 20, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andreimatei, @petermattis, and @tbg)
pkg/cmd/roachtest/clearrange.go, line 93 at r3 (raw file):
// declare itself ready before it's actually 100% ready. See: // https://github.com/cockroachdb/cockroach/issues/34897#issuecomment-465089057 c.Run(ctx, c.Node(1), `COCKROACH_CONNECT_TIMEOUT=120 ./cockroach sql --insecure -e "DROP DATABASE IF EXISTS tinybank"`)
Ick. Ok, but ick.
|
TFTR! bors r=petermattis Ack on the ick. |
|
👎 Rejected by PR status |
See cockroachdb#34897 (comment). Release note: None
|
Hrm, somehow the CLA won't turn green. I force-pushed and also clicked "recheck PRs" on cla-assistant.io. Any other ideas? |
|
I even checked that the cla-assistant recheck request goes through (it does after ~49s) but the payload and response are mostly arrays of |
|
Thanks @bdarnell for redelivering the webhook. bors r=petermattis |
craig bot
pushed a commit
that referenced
this pull request
Feb 20, 2019
35050: roachtest: misc clearrange improvements r=petermattis a=tbg Touches #34897. Release note: None Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Touches #34897.
Release note: None