sql: prevent UPDATE from crashing if subquery returns no rows #34804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: only the heuristic planner was affected. The CBO was handling this case fine already. Release note (bug fix): When using `UPDATE SET (a,b) = (...subquery...)`, CockroachDb will not crash any more if the subquery returns no rows.
|
This change is |
This was referenced Feb 11, 2019
|
Why create the empty result every time? Just create it when the subquery
is returning an empty result.
…On Mon, Feb 11, 2019, 17:48 cockroach-teamcity ***@***.*** wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/34804>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#34804 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABihuX-YiJeplRdGVRPV9U_sc-e2oChqks5vMfM1gaJpZM4a1OD5>
.
|
|
Can you re-read the change - I think the tuple is allocated just once during planning. |
|
Ah. ExtractValues is run for every row.
LGTM
…On Mon, Feb 11, 2019, 17:58 kena ***@***.*** wrote:
Can you re-read the change - I think the tuple is allocated just once
during planning.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#34804 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABihuR0OSJq0Xc1DjJ9wNkjWFho0fDYRks5vMfWagaJpZM4a1OD5>
.
|
|
TFYR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Feb 12, 2019
34804: sql: prevent UPDATE from crashing if subquery returns no rows r=knz a=knz Fixes #32054. Note: only the heuristic planner was affected. The CBO was handling this case fine already. Release note (bug fix): When using `UPDATE SET (a,b) = (...subquery...)`, CockroachDb will not crash any more if the subquery returns no rows. Co-authored-by: Raphael 'kena' Poss <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32054.
Note: only the heuristic planner was affected. The CBO was handling
this case fine already.
Release note (bug fix): When using
UPDATE SET (a,b) = (...subquery...), CockroachDb will not crash any more if thesubquery returns no rows.