changefeedccl: fix bugs with cloud sink s3 and resolved filename ordering #34247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop truncating the logical part of the hlc timestamp from the filenames. This also allows us to stop doing the subtraction of a nanosecond when generating filenames for resolved timestamps, which was surprising and led to a bug. I was trying to make the filenames shorter, but it's time to give up and do the obvious thing for now. Release note (bug fix): The `CHANGEFEED` experimental could sink now orders resolved timestamp files correctly.
Found in preliminary acceptance testing. The cloudStorageSink doesn't know about the params each ExportStorage accepts, so it was rejecting them as unknown, preventing use of the s3 sink. It'd be great if ExportStorage could error if it then got a param it didn't understand, but this is a thread I don't have time to pull right now. Release note (bug fix): The `CHANGEFEED` experimental cloud sink now supports s3 auth params.
|
This change is |
tbg
approved these changes
Jan 25, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @tbg)
tbg
approved these changes
Jan 25, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:
|
TFTR! bors r=tbg |
craig bot
pushed a commit
that referenced
this pull request
Jan 25, 2019
34247: changefeedccl: fix bugs with cloud sink s3 and resolved filename ordering r=tbg a=danhhz See commits for details. Co-authored-by: Daniel Harrison <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.