roachtest: ignore unrelated tags when looking for build version #33446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
bdarnell
approved these changes
Jan 2, 2019
benesch
approved these changes
Jan 2, 2019
There was a problem hiding this comment.
Can you make the same changes here?
Line 1007 in 94516a1
cockroach/pkg/cmd/internal/issues/issues.go
Line 143 in 94516a1
cockroach/scripts/release-notes.py
Lines 722 to 723 in 94516a1
cockroach/build/teamcity-post-failures.py
Line 66 in 94516a1
🙈
Release note: None
danhhz
force-pushed
the
release_process
branch
from
e3f8331 to
7146751
Compare
|
Done. That's some nice grepping |
benesch
approved these changes
Jan 2, 2019
|
Thanks for the reviews! bors r=bdarnell,benesch |
craig bot
pushed a commit
that referenced
this pull request
Jan 2, 2019
33020: sql, roachpb: save representative logical plans in statement stats r=jordanlewis a=celiala _[This is based off initial work done in #26494]_ We want to show sample logical plans on the Admin UI Statement Details page. This change introduces logic to sample logical plans and store into statement statistics. A future commit will surface theses plans in the Admin UI. Every `n` times a query with a particular fingerprint is run (currently n is hardcoded to 1000), convert its logical plan to a simplified form suitable for serialization to JSON or protobuf, and save that plan in memory as part of the StatementStatistics struct. Since the admin server's `Queries` method returns the full, unscrubbed StatementStats proto for each fingerprint, this change exposes these plans to the admin UI, via [the newly-created] StatementStatistics.SensitiveInfo. Notes: - A future commit could scrub the plans so they can be sent to the reg cluster. - This implementation uses query plans; however, we can adapt this to use the optimizer later, if desired. - Over time, we may also want to consider moving the statement reporting code into a goroutine that isn't the primary execution goroutine, both for performance reasons and for failure isolation ones. Release note (sql change): Sample logical plans and store into statement statistics. 33446: roachtest: ignore unrelated tags when looking for build version r=bdarnell,benesch a=danhhz Release note: None Co-authored-by: Pete Vilter <[email protected]> Co-authored-by: Celia La <[email protected]> Co-authored-by: Daniel Harrison <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None