ui: indicate direction on node latency table #33299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
|
This change is |
couchand
approved these changes
Jan 7, 2019
There was a problem hiding this comment.
Thanks for knocking this out @tbg! I've always forgotten which direction is which on that table.
cc @piyush-singh let's take this into account when we bring this into the main pages
| function createHeaderCell(staleIDs: Set<number>, id: Identity, key: string) { | ||
| const node = `n${id.nodeID.toString()}`; | ||
| function createHeaderCell(staleIDs: Set<number>, id: Identity, key: string, titlePrefix: string) { | ||
| const node = titlePrefix + `n${id.nodeID.toString()}`; |
There was a problem hiding this comment.
style nit: add to the interpolated string:
const node = `${titlePrefix}n${id.nodeID.toString()}`
| @@ -285,14 +285,15 @@ class Network extends React.Component<NetworkProps, {}> { | |||
| staleIDs, | |||
| identity, | |||
| `0-${identity.nodeID}`, | |||
| `to `, | |||
There was a problem hiding this comment.
style nit: just use a plain string: 'to '
| )) | ||
| } | ||
| </tr> | ||
| { | ||
| _.map(displayIdentities, (identityA) => ( | ||
| <tr key={identityA.nodeID} className="network-table__row"> | ||
| { | ||
| createHeaderCell(staleIDs, identityA, `${identityA.nodeID}-0`) | ||
| createHeaderCell(staleIDs, identityA, `${identityA.nodeID}-0`, ``) |
There was a problem hiding this comment.
style nit: maybe a default parameter, or at least use a plain string: ''?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None