Clear instead of del; clearRange #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Rename del() to clear() in engine.go Add clearRange() to engine.go Test in engine_test.go Test Plan: go test Reviewers: spencerkimball, lancevac Subscribers: team Differential Revision: http://phabricator.cockroachdb.org/D104
|
See http://phabricator.cockroachdb.org/D104 - will merge once CI completes. |
maniksurtani
added a commit
that referenced
this pull request
Jul 30, 2014
Clear instead of del; clearRange
tbg
added a commit
that referenced
this pull request
Aug 31, 2016
We have been seeing long startup times which disappear spontaneously. During a
restart of the beta cluster, the following goroutine was observed, which suggests
that we were spending a lot of time GCing replicas on startup.
engine ??:0 _Cfunc_DBIterNext(#324, #323, 0, 0, 0, 0, 0, 0, 0)
engine rocksdb.go:1135 (*rocksDBIterator).Next(#235)
storage replica_data_iter.go:104 (*ReplicaDataIterator).Next(#316)
storage store.go:1748 (*Store).destroyReplicaData(#109, #317, 0, 0)
storage store.go:841 (*Store).Start.func2(0x101b, #300, 0x36, 0x40, #301, 0x36, 0x40, #315, 0x3, 0x4, ...)
storage store.go:734 IterateRangeDescriptors.func1(#306, 0x40, 0x41, #307, 0x92, 0x92, #341, 0, 0x186c, 0x4000, ...)
engine mvcc.go:1593 MVCCIterate(#329, #68, #47, #81, #232, 0x9, 0x10, #233, 0xb, 0x10, ...)
storage store.go:738 IterateRangeDescriptors(#330, #196, #47, #81, #195, #179, #110)
storage store.go:867 (*Store).Start(#109, #330, #196, #179, #185, 0x1)
server node.go:405 (*Node).initStores(#78, #330, #196, #98, 0x1, 0x1, #179, 0, #55)
server node.go:330 (*Node).start(#78, #330, #196, #42, #129, #98, 0x1, 0x1, 0, 0, ...)
server server.go:431 (*Server).Start(#5, #330, #196, #95, 0x1)
cli start.go:368 runStart(#34, #178, 0, 0x9, 0, 0)
cobra command.go:599 (*Command).execute(#34, #177, 0x9, 0x9, #34, #177)
cobra command.go:689 (*Command).ExecuteC(#33, #70, #343, #72)
cobra command.go:648 (*Command).Execute(#33, #71, #343)
cli cli.go:96 Run(#64, 0xa, 0xa, 0, 0)
main main.go:37 main()
soniabhishek
pushed a commit
to soniabhishek/cockroach
that referenced
this pull request
Feb 15, 2017
Adding multiple level logging and refactoring
pav-kv
pushed a commit
to pav-kv/cockroach
that referenced
this pull request
Mar 5, 2024
raft: protect unstable.entries slice from appends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Rename del() to clear() in engine.go
Add clearRange() to engine.go
Test in engine_test.go
Test Plan: go test
Reviewers: spencerkimball, lancevac
Subscribers: team
Differential Revision: http://phabricator.cockroachdb.org/D104