backport-2.1: batcheval: Disable time-bound iterators in KV commands #32318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test verifies that the workaround introduced in cockroachdb#32211 is effective (and that whatever permanent fix we eventually replace it with doesn't reintroduce the bug). Release note: None
This optimization has not been shown to make a difference in benchmarks, and there are doubts about its correctness (cockroachdb#28358). It is still used for CDC (where it does make a difference) and incremental backups. Release note: None
This reverts commit ad54ae6. Release note: None
|
This change is |
|
@cockroachdb/release |
benesch
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimization has not been shown to make a difference in
benchmarks, and there are doubts about its correctness (#28358). It is
still used for CDC (where it does make a difference) and incremental
backups.