sql: let AS OF SYSTEM TIME requests use table descriptor cache #31716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @nvanbenschoten |
dt
approved these changes
Oct 23, 2018
nvanbenschoten
approved these changes
Oct 23, 2018
|
This code is tested through TestAsOfTime and TestTxnCanStillResolveOldName, so the approach is correct. The only problem with this change is that it's not testing that the cache is indeed being used. Let me add a test just for that. |
|
Added TestAsOfSystemTimeUsingCache |
|
bors r+ |
Build failed |
This change also fixes a problem where TRUNCATE was not setting the ModificationTime on the descriptor. This change also fixes a bug where we were not using Timestamp.Prev() to compute the previous timestamp when reading the previous version of a descriptor. This change disables the use of the descriptor cache when AS OF SYSTEM TIME is for a timestamp before a DROP or a TRUNCATE on a table because of a bug in AcquireByName(). fixes cockroachdb#30967 Release note (sql change): Speedup AS OF SYSTEM TIME requests by letting them use the table descriptor cache.
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 23, 2018
31644: storage: remove excessive new range lease logging r=spencerkimball a=spencerkimball Release note: None 31716: sql: let AS OF SYSTEM TIME requests use table descriptor cache r=vivekmenezes a=vivekmenezes This change also fixes a problem where TRUNCATE was not setting the ModificationTime on the descriptor. This change also fixes a bug where we were not using Timestamp.Prev() to compute the previous timestamp when reading the previous version of a descriptor. This change disables the use of the descriptor cache when AS OF SYSTEM TIME is for a timestamp before a DROP or a TRUNCATE on a table because of a bug in AcquireByName(). fixes #30967 Release note (sql change): Speedup AS OF SYSTEM TIME requests by letting them use the table descriptor cache. Co-authored-by: Spencer Kimball <[email protected]> Co-authored-by: Vivek Menezes <[email protected]>
Build succeeded |
vivekmenezes
added a commit
to vivekmenezes/cockroach
that referenced
this pull request
Oct 24, 2018
This change removes the fixedTimestamp bit introduced in cockroachdb#31716 It also explains problem cockroachdb#18354 with LeaseManager.Acquire() through a comment and implements a work around bypassing the cache and reading the descriptor directly from the store. It also fixes a problem with UncachedPhysicalAccessor.GetObjectDesc tested through TestTxnCanStillResolveOldName. related to cockroachdb#30967 fixes cockroachdb#18354 fixes cockroachdb#19925 Release note: None
vivekmenezes
added a commit
to vivekmenezes/cockroach
that referenced
this pull request
Oct 30, 2018
This change removes the fixedTimestamp bit introduced in cockroachdb#31716 It also explains problem cockroachdb#18354 with LeaseManager.Acquire() through a comment and implements a work around bypassing the cache and reading the descriptor directly from the store. It also fixes a problem with UncachedPhysicalAccessor.GetObjectDesc tested through TestTxnCanStillResolveOldName. related to cockroachdb#30967 fixes cockroachdb#18354 fixes cockroachdb#19925 Release note: None
vivekmenezes
added a commit
to vivekmenezes/cockroach
that referenced
this pull request
Nov 1, 2018
This change removes the fixedTimestamp bit introduced in cockroachdb#31716 It also explains problem cockroachdb#18354 with LeaseManager.Acquire() through a comment and implements a work around bypassing the cache and reading the descriptor directly from the store. It also fixes a problem with UncachedPhysicalAccessor.GetObjectDesc tested through TestTxnCanStillResolveOldName. related to cockroachdb#30967 fixes cockroachdb#18354 fixes cockroachdb#19925 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Nov 1, 2018
31776: sql: cleanup AS OF SYSTEM TIME query descriptor cache lookup r=vivekmenezes a=vivekmenezes This change removes the fixedTimestamp bit introduced in #31716 It also explains problem #18354 with LeaseManager.Acquire() through a comment and implements a work around bypassing the cache and reading the descriptor directly from the store. It also fixes a problem with UncachedPhysicalAccessor.GetObjectDesc tested through TestTxnCanStillResolveOldName. related to #30967 fixes #18354 fixes #19925 Release note: None Co-authored-by: Vivek Menezes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also fixes a problem where TRUNCATE was not
setting the ModificationTime on the descriptor.
This change also fixes a bug where we were not using
Timestamp.Prev() to compute the previous timestamp
when reading the previous version of a descriptor.
This change disables the use of the descriptor cache
when AS OF SYSTEM TIME is for a timestamp before
a DROP or a TRUNCATE on a table because of a bug
in AcquireByName().
fixes #30967
Release note (sql change): Speedup AS OF SYSTEM TIME requests by
letting them use the table descriptor cache.