[wip] ui: link to debug pages in sidebar #31034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
couchand
reviewed
Oct 8, 2018
| <div> | ||
| <div | ||
| className="login-indicator__initial" | ||
| title={`Signed in as ${user}`} |
There was a problem hiding this comment.
as long as you're in here, can you update this to use TooltipWrapper please?
There was a problem hiding this comment.
More CSS struggles when I insert the ToolTipWrapper :P
| @@ -128,6 +137,13 @@ export default class Sidebar extends React.Component { | |||
| <IconLink to="/jobs" icon={jobsIcon} title="Jobs" /> | |||
| </ul> | |||
| <ul className="navigation-bar__list navigation-bar__list--bottom"> | |||
| <li> | |||
| <Link to="/debug" className={classNames("debug-pages-link", { active: this.context.router.isActive("/debug") })}> | |||
There was a problem hiding this comment.
Tried to use IconLink — it pulls in a lot of CSS which I was unable to finagle to get the spacing I wanted. Maybe will be more successful today.
|
also closes #29310 |
Release note: None
|
Edits for note at the top of the page: |
vilterp
force-pushed
the
expose-debug-pages
branch
from
3f785ad to
8d80543
Compare
Release note: None
vilterp
force-pushed
the
expose-debug-pages
branch
from
8d80543 to
714b541
Compare
Release note: None
vilterp
force-pushed
the
expose-debug-pages
branch
from
714b541 to
3dbd65d
Compare
|
closing in favor of #31218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Fixes #20690