release-2.1: cli: Mark zone command deprecated so it doesn't show up in help text #30808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had previously marked zone's subcommands as deprecated in bfc190d, which meant they didn't show up as available subcommands in the help text of `cockroach zone`. However, there was no deprecation message on the zone command itself, which made the lack of subcommands confusing, and also meant that it showed up as a command in the help text of the top level `cockroach` command. This fixes both issues. Release note: None
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #30747.
/cc @cockroachdb/release
We had previously marked zone's subcommands as deprecated in
bfc190d, which meant they didn't show
up as available subcommands in the help text of
cockroach zone.However, there was no deprecation message on the zone command itself,
which made the lack of subcommands confusing, and also meant that it
showed up as a command in the help text of the top level
cockroachcommand. This fixes both issues.
Release note: None