sql: fix panic with null delimiter in string_agg #28837
Conversation
|
This change is |
There was a problem hiding this comment.
Nice catch!
Please add a logic test for this.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
pkg/sql/sem/builtins/aggregate_builtins.go, line 642 at r1 (raw file):
// via the first element in others. if len(others) == 1 { if others[0] == tree.DNull {
This behaviour is incorrect. In postgres, using a NULL in both a window function or normal aggregate, the result is to treat it as an empty delimiter.
|
I added a logic test containing this massive query that caught the bug. I actually can't figure out how to reproduce with just a simple window function! Maybe we could sit together and look at it? |
Closes cockroachdb#28836. Release note: None
jordanlewis
force-pushed
the
fix-null-concat-agg
branch
from
e90c021 to
8900d13
Compare
|
Reduced the test case. PTAL |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:
|
bors r+ |
28837: sql: fix panic with null delimiter in string_agg r=jordanlewis a=jordanlewis Closes #28836. Release note: None Co-authored-by: Jordan Lewis <[email protected]>
Build succeeded |
Closes #28836.
Release note: None