-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump dep to fix dependency resolution bug #28831
Conversation
🤔 |
The version of dep we had vendored previously, v0.4.1, somehow dropped a Windows-only dependency, github.com/shirou/w32, on the floor. Upgrade to dep v0.5.0, which correctly brings in that dependency. Release note: None
Well that was utterly baffling. I could only reproduce that diff by running |
Ok, I'm not going to think too hard about this because everything is happy now. Merging! bors r=dt |
28831: build: bump dep to fix dependency resolution bug r=dt a=benesch The version of dep we had vendored previously, v0.4.1, somehow dropped a Windows-only dependency, github.com/shirou/w32, on the floor. Upgrade to dep v0.5.0, which correctly brings in that dependency. Release note: None Co-authored-by: Nikhil Benesch <[email protected]>
good call -- if you gaze too long into the abyss of a package manager, the abyss also gazes into you |
Build succeeded |
The version of dep we had vendored previously, v0.4.1, somehow dropped a
Windows-only dependency, github.com/shirou/w32, on the floor. Upgrade to
dep v0.5.0, which correctly brings in that dependency.
Release note: None