server: capture info about hardware and OS in diagnostics #28676
Conversation
|
This change is |
| message HardwareInfo { | ||
| CPUInfo cpu = 1 [(gogoproto.nullable) = false]; | ||
| MemInfo mem = 2 [(gogoproto.nullable) = false]; | ||
| float loadavg = 3; |
There was a problem hiding this comment.
note that it's the 15 minute average
| @@ -32,6 +32,7 @@ message DiagnosticReport { | |||
| map<string, int64> error_counts = 7; | |||
| map<int64, config.ZoneConfig> zone_configs = 8 [(gogoproto.nullable) = false]; | |||
| map<string, int32> feature_usage = 9 [(gogoproto.nullable) = false]; | |||
|
|
|||
There was a problem hiding this comment.
For testing, we'll just have to make sure that there are values present and not default ones for everything except for the virtualization stuff I think. Just make sure it runs properly on TC and we can get a linux user to test on their machine too.
The proto needs a wee bit of cleanup, and we should take a look at the cloud stuff in another PR.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
dt
force-pushed
the
hardware
branch
3 times, most recently
from
95fcd04 to
d223a16
Compare
Information about the machines we’re running on, such as number of cores memory or OS version will help us identify commonly used deployment Configurations that we can then consider when testing and tuning, e.g. picking size caches, writing deployment recommendations, etc. Release note(general change): Include hardware and OS information in the anonymous diagnostics reporting sent to Cockroach Labs if enabled.
|
as discussed, moved virtualization to |
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2.
Reviewable status:
|
bors r+ |
28676: server: capture info about hardware and OS in diagnostics r=dt a=dt Information about cores and memory commonly used to run Cockroach can help us size caches, tune recommendations, etc. First draft of what we discussed. Will need to think about testing a bit though. Co-authored-by: David Taylor <[email protected]>
Build succeeded |
|
Ben noted on a different PR that the CPU info returned by gopsutil isn't consistent across platforms in how it reports sockets vs cores vs threads: #27662 (review) So we should use caution while interpreting those numbers, or find another library for CPU info (I don't know of one offhand). However, I think the |
|
@vilterp yep, we have |
|
Yes, we should primarily look at |
Information about cores and memory commonly used to run Cockroach can help us size caches, tune recommendations, etc.
First draft of what we discussed. Will need to think about testing a bit though.