Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/sem/tree: fix the pretty-printing for IMPORT #28568

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

knz
Copy link
Contributor

@knz knz commented Aug 14, 2018

Fixes #28562.

The IMPORT statement didn't roundtrip properly. This patch fixes it.

Also the contextual help is extended to include the new IMPORT syntax.

Release note: None

The IMPORT statement didn't roundtrip properly. This patch fixes it.

Also the contextual help is extended to include the new IMPORT syntax.

Release note: None
@knz knz requested review from maddyblue and BramGruneir August 14, 2018 09:34
@knz knz requested review from a team August 14, 2018 09:34
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@BramGruneir BramGruneir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale)

@knz
Copy link
Contributor Author

knz commented Aug 14, 2018

thank you!

bors r+

craig bot pushed a commit that referenced this pull request Aug 14, 2018
28568: sql/sem/tree: fix the pretty-printing for IMPORT r=knz a=knz

Fixes #28562.

The IMPORT statement didn't roundtrip properly. This patch fixes it.

Also the contextual help is extended to include the new IMPORT syntax.

Release note: None

Co-authored-by: Raphael 'kena' Poss <[email protected]>
@craig
Copy link
Contributor

craig bot commented Aug 14, 2018

Build succeeded

@craig craig bot merged commit e2ea44e into cockroachdb:master Aug 14, 2018
@maddyblue
Copy link
Contributor

Thanks!

@knz knz deleted the 20180814-fix-import branch February 14, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: IMPORT pretty-print error
4 participants