distsql: add flow setup cluster settings and improve debuggability #27404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
requested changes
Jul 11, 2018
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained
pkg/sql/distsqlrun/flow_scheduler.go, line 77 at r1 (raw file):
fs.mu.queue = list.New() settingMaxRunningFlows.SetOnChange(&settings.SV, func() { fs.maxRunningFlows = int(settingMaxRunningFlows.Get(&settings.SV))
Isn't there a race here?
This gives users the ability to increase the default flow stream timeout
to avoid inbound stream connection errors as well as controlling the
maximum number of running flows on a node.
Release note (sql change): Add sql.distsql.{flow_stream_timeout,
max_running_flows} cluster settings to fine tune flow setup
Release note: None
asubiotto
commented
Jul 11, 2018
There was a problem hiding this comment.
Reviewable status:
pkg/sql/distsqlrun/flow_scheduler.go, line 77 at r1 (raw file):
Previously, RaduBerinde wrote…
Isn't there a race here?
Yup, thanks for catching!
RaduBerinde
approved these changes
Jul 11, 2018
There was a problem hiding this comment.
Reviewable status:
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 12, 2018
27404: distsql: add flow setup cluster settings and improve debuggability r=asubiotto a=asubiotto This change adds flow setup-related cluster settings to give users the flexibility of increasing the default flow stream timeout to avoid inbound stream connection errors as well as controlling the maximum number of running flows on a node. Log messages have also been added to the flow scheduler to provide more insight into its operations and improve debugging. Co-authored-by: Alfonso Subiotto Marqués <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds flow setup-related cluster settings to give users the flexibility of increasing the default flow stream timeout to avoid inbound stream connection errors as well as controlling the maximum number of running flows on a node. Log messages have also been added to the flow scheduler to provide more insight into its operations and improve debugging.