importccl: set descriptor DropTime during failed IMPORT #26959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows ClearRange to be used instead of the 1.1-era batch deletions. Release note (bug fix): failed IMPORTs will now begin to clean up partially imported data immediatily and in a faster manner.
|
This change is |
benesch
approved these changes
Jun 25, 2018
There was a problem hiding this comment.
LGTM, but also good with removing the legacy code. Feel free to leave to another PR (or to me/@vivekmenezes), especially if you might want to backport this.
dt
approved these changes
Jun 25, 2018
|
bors r+ |
Merge conflict (retrying...) |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 26, 2018
26959: importccl: set descriptor DropTime during failed IMPORT r=mjibson a=mjibson This allows ClearRange to be used instead of the 1.1-era batch deletions. Release note (bug fix): failed IMPORTs will now begin to clean up partially imported data immediatily and in a faster manner. Co-authored-by: Matt Jibson <[email protected]>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Jun 26, 2018
26986: release-2.0: importccl: set descriptor DropTime during failed IMPORT r=mjibson a=mjibson Backport 1/1 commits from #26959. /cc @cockroachdb/release --- This allows ClearRange to be used instead of the 1.1-era batch deletions. Release note (bug fix): failed IMPORTs will now begin to clean up partially imported data immediatily and in a faster manner. Co-authored-by: Matt Jibson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows ClearRange to be used instead of the 1.1-era batch deletions.
Release note (bug fix): failed IMPORTs will now begin to clean up
partially imported data immediatily and in a faster manner.