Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: tick only raft groups which are not quiesced #26910

Merged
merged 1 commit into from
Jun 26, 2018
Merged

storage: tick only raft groups which are not quiesced #26910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions pkg/storage/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3716,15 +3716,16 @@ func (s *Store) raftTickLoop(ctx context.Context) {
case <-ticker.C:
rangeIDs = rangeIDs[:0]

s.mu.replicas.Range(func(k int64, v unsafe.Pointer) bool {
// Why do we bother to ever queue a Replica on the Raft scheduler for
// tick processing? Couldn't we just call Replica.tick() here? Yes, but
// then a single bad/slow Replica can disrupt tick processing for every
// Replica on the store which cascades into Raft elections and more
// disruption.
rangeIDs = append(rangeIDs, roachpb.RangeID(k))
return true
})
s.unquiescedReplicas.Lock()
// Why do we bother to ever queue a Replica on the Raft scheduler for
// tick processing? Couldn't we just call Replica.tick() here? Yes, but
// then a single bad/slow Replica can disrupt tick processing for every
// Replica on the store which cascades into Raft elections and more
// disruption.
for rangeID := range s.unquiescedReplicas.m {
rangeIDs = append(rangeIDs, rangeID)
}
s.unquiescedReplicas.Unlock()

s.scheduler.EnqueueRaftTick(rangeIDs...)
s.metrics.RaftTicks.Inc(1)
Expand Down