Bump RocksDB pointer to grab facebook/rocksdb#3926 #26754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RocksDB was violating an invariant that no 2 sstables in a level overlap. It isn't quite clear what the upshot of this violation is. At the very least it would cause the overlapping tables to be compacted together. It seems possible that it could lead to missing writes, but I haven't been able to verify that. Fixes cockroachdb#26693 Release note: None
|
This change is |
|
Note that I'm not actually sure that this fixes the excessive compactions in #26693, but it does fix the RocksDB assertion. I'll create a new issue to track the excessive compactions problem. |
a-robinson
approved these changes
Jun 15, 2018
benesch
approved these changes
Jun 15, 2018
|
bors r=benesch,a-robinson |
craig bot
pushed a commit
that referenced
this pull request
Jun 15, 2018
26753: storage: Add extra event to allocator rebalancing r=a-robinson a=a-robinson Helps make the output of simulated allocator runs less confusing, since otherwise it's not clear why we're considering removal from the range and why the replicas being considered for removal includes one that isn't even a real member of the range. Release note: None Would have made looking at the simulated allocator output from https://forum.cockroachlabs.com/t/how-to-enable-leaseholder-load-balancing/1732/3 a little more pleasant. 26754: Bump RocksDB pointer to grab facebook/rocksdb#3926 r=benesch,a-robinson a=petermattis RocksDB was violating an invariant that no 2 sstables in a level overlap. It isn't quite clear what the upshot of this violation is. At the very least it would cause the overlapping tables to be compacted together. It seems possible that it could lead to missing writes, but I haven't been able to verify that. Fixes #26693 Release note: None Co-authored-by: Alex Robinson <[email protected]> Co-authored-by: Peter Mattis <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RocksDB was violating an invariant that no 2 sstables in a level
overlap. It isn't quite clear what the upshot of this violation is. At
the very least it would cause the overlapping tables to be compacted
together. It seems possible that it could lead to missing writes, but I
haven't been able to verify that.
Fixes #26693
Release note: None