server: use the right ctx when logging an error #26706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using a context that was potentially long gone, leading to a span use-after-free crash. Fixes cockroachdb#25389 Release note (bug fix): Fixed a rare crash on node decomissioning.
|
This change is |
asubiotto
approved these changes
Jun 13, 2018
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 13, 2018
26706: server: use the right ctx when logging an error r=andreimatei a=andreimatei We were using a context that was potentially long gone, leading to a span use-after-free crash. Fixes #25389 Release note (bug fix): Fixed a rare crash on node decomissioning. Co-authored-by: Andrei Matei <[email protected]>
Build succeeded |
|
Are you sure you fixed something here? cockroach/pkg/util/stop/stopper.go Line 186 in 229d25d |
|
The closure wasn't using the ctx that's passed in as an argument - the argument is unnamed. It was using the caller's ctx directly. |
|
Oh, I missed that. Jeez, subtle. |
craig bot
pushed a commit
that referenced
this pull request
Jun 14, 2018
26717: cherrypick 2.0: server: use the right ctx when logging an error r=andreimatei a=andreimatei Cherry-pick of #26706 We were using a context that was potentially long gone, leading to a span use-after-free crash. Fixes #25389 Release note (bug fix): Fixed a rare crash on node decomissioning. Co-authored-by: Andrei Matei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a context that was potentially long gone, leading to a
span use-after-free crash.
Fixes #25389
Release note (bug fix): Fixed a rare crash on node decomissioning.