Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: quiescence with dead node #26542

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

tbg
Copy link
Member

@tbg tbg commented Jun 8, 2018

This test currently fails, at least in remote mode (curiously in local
mode it works, at least on my laptop).

--- FAIL: kv/quiescence/nodes=3 [unstable] (1258.49s)
        kv.go:160: QPS dropped by more than 80%: from 2669.32 to 1582.14

Fixing this test is the goal for #9446.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@petermattis
Copy link
Collaborator

:lgtm:

I like that we're adding roachtests for scenarios like this.


Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks failed.


pkg/cmd/roachtest/kv.go, line 145 at r1 (raw file):

			const kv = "./workload run kv --duration=10m --read-percent=0"

			run("./workload run kv --init --max-ops=1 --splits 10000 --concurrency 100 {pgurl:1}", false)

I'm guessing 10k splits is necessary to highlight the lack of quiescence. Should indicate that in a comment.


Comments from Reviewable

This test currently fails, at least in remote mode (curiously in local
mode it works, at least on my laptop).

```
--- FAIL: kv/quiescence/nodes=3 [unstable] (1258.49s)
        kv.go:160: QPS dropped by more than 80%: from 2669.32 to 1582.14
```

Fixing this test is the goal for cockroachdb#9446.

Release note: None
@tbg tbg force-pushed the roachtest/quiescing branch from a1fc8ce to 4aedb39 Compare June 8, 2018 20:11
@tbg
Copy link
Member Author

tbg commented Jun 8, 2018

Updated. TFTR!

bors r=petermattis

craig bot pushed a commit that referenced this pull request Jun 8, 2018
26542: roachtest: quiescence with dead node r=petermattis a=tschottdorf

This test currently fails, at least in remote mode (curiously in local
mode it works, at least on my laptop).

```
--- FAIL: kv/quiescence/nodes=3 [unstable] (1258.49s)
        kv.go:160: QPS dropped by more than 80%: from 2669.32 to 1582.14
```

Fixing this test is the goal for #9446.

Release note: None

Co-authored-by: Tobias Schottdorf <[email protected]>
@craig
Copy link
Contributor

craig bot commented Jun 8, 2018

Build succeeded

@craig craig bot merged commit 4aedb39 into cockroachdb:master Jun 8, 2018
@tbg tbg deleted the roachtest/quiescing branch June 25, 2018 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants