roachtest: perform spec validation on existing clusters

[nvanbenschoten]

This change adds in a new validation step when running tests with the
--cluster flag to verify that the cluster matches the test spec. This
is particularly important for benchmarks, which can produce vastly
different results depending on the machine type they run on.

Release note: None

[cockroach-teamcity]

This change is 

[petermattis]

---

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

pkg/cmd/roachtest/cluster.go, line 504 at r1 (raw file):

		//
		// TODO DURING REIVIEW: we could use the roachprod.Cloud struct directly
		// for this if we were ok establishing the dependency.

I'd prefer to avoid that dependency. This looks good to me.

---

pkg/cmd/roachtest/cluster.go, line 507 at r1 (raw file):

		type jsonOutput struct {
			Clusters map[string]struct {
				Vms []struct {

s/Vms/VMs/g

---

pkg/cmd/roachtest/cluster.go, line 534 at r1 (raw file):

				}
			}
			// TODO DURING REVIEW: should we assert correct zones?

That seems overly restrictive. Perhaps we wanted to use different zones for some reason.

---

Comments from Reviewable

[nvanbenschoten]

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions, some commit checks pending.

---

pkg/cmd/roachtest/cluster.go, line 504 at r1 (raw file):

Previously, petermattis (Peter Mattis) wrote…

I'd prefer to avoid that dependency. This looks good to me.

Done.

---

pkg/cmd/roachtest/cluster.go, line 507 at r1 (raw file):

Previously, petermattis (Peter Mattis) wrote…

s/Vms/VMs/g

Done.

---

pkg/cmd/roachtest/cluster.go, line 534 at r1 (raw file):

Previously, petermattis (Peter Mattis) wrote…

That seems overly restrictive. Perhaps we wanted to use different zones for some reason.

Yeah, that's what I figured. We can add in some extra zone validation if we find that we need it.

---

Comments from Reviewable

[nvanbenschoten]

bors r+

[craig]

Build succeeded

• GitHub CI (Cockroach)