opt/optbuilder: Fix bug with ORDER BY and aggregate alias #25455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in which ordering by an alias of an aggregate causes an error. Queries such as: `SELECT SUM(a) AS a2 FROM abcd GROUP BY c ORDER BY a2` were incorrectly causing the error: `error: column "a2" must appear in the GROUP BY clause or be used in an aggregate function` This commit fixes that issue, so now the query builds successfully. Release note: None
|
This change is |
|
Review status: 0 of 2 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
Wow that was fast! TFTR :) Review status: 0 of 2 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
bors r+ Review status: 0 of 2 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
craig bot
pushed a commit
that referenced
this pull request
May 13, 2018
25455: opt/optbuilder: Fix bug with ORDER BY and aggregate alias r=rytaft a=rytaft This commit fixes a bug in which ordering by an alias of an aggregate causes an error. Queries such as: `SELECT SUM(a) AS a2 FROM abcd GROUP BY c ORDER BY a2` were incorrectly causing the error: `error: column "a2" must appear in the GROUP BY clause or be used in an aggregate function` This commit fixes that issue, so now the query builds successfully. Release note: None Co-authored-by: Rebecca Taft <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in which ordering by an alias of
an aggregate causes an error.
Queries such as:
SELECT SUM(a) AS a2 FROM abcd GROUP BY c ORDER BY a2were incorrectly causing the error:
error: column "a2" must appear in the GROUP BY clause or be used in an aggregate functionThis commit fixes that issue, so now the query builds successfully.
Release note: None